#32 almost a proper close button

submitted on by Manuel

Bad code

<button display="flex" role="button">
<svg role="img" viewBox="0 0 13 13" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" height="15px" width="15px" fill="#000" name="close">
<title>Close dialog</title>
<path d=""> </path>

Issues and how to fix them

  1. Either turn the <svg> into a semantic element (role="img") or exclude it from the accessibility tree (aria-hidden="true"). Doing both makes no sense.
  2. The button has no accessible name (a text alternative). The title element in the svg would serve as the accessible name, but aria-hidden="true" makes the whole SVG inaccessible to assistive technology.
  3. Even without aria-hidden="true", some screen reader/browser combinations might not recognise the <title> element. Label the <svg> using aria-labelledby or aria-label.
  4. The role=button attribute and value for the button is redundant. Its implicit default role is “button”.
  5. There's no display attribute. If you need custom attributes, use the data- prefix.
  6. The name attribute is not allowed on <svg>
  7. The value of the width and height attributes should be a valid non-negative integer.
  8. Add a type="button" attribute and value to prevent the button from submitting a form, if there is one.

Good code

<button type="button" data-display="flex">
<svg role="img" viewBox="0 0 13 13" xmlns="http://www.w3.org/2000/svg" height="15" width="15" fill="#000" aria-labelledby="title">
<title id="title">Close</title>
<path d=""> </path>

Demo of Voice Over on macOS

Voice Over doesn't recognize the title element nested in a svg nested in a button.

Code on CodePen.